Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate replacement comment info in the replacement history #3324

Closed
RaisingK opened this issue Oct 7, 2017 · 2 comments
Closed

Incorporate replacement comment info in the replacement history #3324

RaisingK opened this issue Oct 7, 2017 · 2 comments

Comments

@RaisingK
Copy link
Collaborator

RaisingK commented Oct 7, 2017

The automatic comment generated when a post is replaced is more informative than the corresponding entry in the replacement history.

@BrokenEagle
Copy link
Collaborator

Would it be beneficial to allow approvers to also add a comment, or maybe select a reason from a list of reasons like they do for disapprovals, for replacing a post. As it is now, I've seen some replacements that were unexplainable, especially those that replace the image source with something from a completely different site.

http://danbooru.donmai.us/post_replacements?page=b9617&limit=1

Some ideas for a list could include...

  1. Sample size
  2. Non-revision (but MD5 is different)
  3. Better version (for instances of extreme artifacts)
  4. Other (specify with a comment)

@evazion
Copy link
Member

evazion commented Dec 19, 2017

#3324 implements this. Existing replacements will need to have their data filled in.

It will be possible to update a replacement's data with PUT /post_replacements/:id.json?post_replacement[md5]=.... Someone will need to scrape the data from the comments and update old replacements accordingly, though.

Letting approvers specify a reason is not a bad idea, although perhaps not as useful now that replacing is Mod-only. I'll leave this open for the idea anyway.

r888888888 added a commit that referenced this issue Dec 19, 2017
Fix #3324: Incorporate replacement comment info in the replacement history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants