Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliased tags are showing up under translated tags #3450

Closed
BrokenEagle opened this issue Dec 23, 2017 · 1 comment
Closed

Aliased tags are showing up under translated tags #3450

BrokenEagle opened this issue Dec 23, 2017 · 1 comment

Comments

@BrokenEagle
Copy link
Collaborator

User Unbreakable brought this up on Discord. Basically, if an aliased tag has an other wiki entry, it'll show up under the list of translated tags. The example he gave was 俺タワー, which was bringing up both ore_tower and ole_tower, the former which was aliased to the latter.

I deleted the ore_tower wiki which resolved the above issue, but for completeness, the translated tags displayer should reject all tags that have aliases.

evazion added a commit to evazion/danbooru that referenced this issue Dec 23, 2017
Resolves aliases in translated tags. For example, say we lookup `遠坂凛`
and find `tohsaka_rin` and `toosaka_rin`. We apply aliases so that
`tohsaka_rin` becomes `toosaka_rin`, which is then returned as the only
translated tag.
@evazion
Copy link
Member

evazion commented Dec 23, 2017

Instead of filtering out aliased wiki pages, #3453 applies aliases to the found tags and then removes any duplicates. This should give effectively the same results.

r888888888 added a commit that referenced this issue Dec 25, 2017
Fix #3450: Aliased tags show up under translated tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants