Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout when fetching source data from NicoSeiga #3457

Closed
1 of 3 tasks
evazion opened this issue Dec 26, 2017 · 0 comments
Closed
1 of 3 tasks

Timeout when fetching source data from NicoSeiga #3457

evazion opened this issue Dec 26, 2017 · 0 comments

Comments

@evazion
Copy link
Member

evazion commented Dec 26, 2017

Currently anything that involves fetching source data from NicoSeiga is timing out. This includes uploading with the bookmarklet, fetching source data, and searching for artists.

The immediate cause is that after we login to NicoSeiga, we get redirected to www.nicovideo.jp, which is currently down. See here: http://blog.nicovideo.jp/en_info/2017/12/post-067621.html.

The broader issue is not handling network problems gracefully. We should:

  • avoid the request to www.nicovideo.jp (it's unnecessary overhead even when it works)

  • have timeouts on all outgoing HTTP requests.

  • expect HTTP requests to fail and handle failures gracefully when they do occur.

r888888888 added a commit that referenced this issue Dec 27, 2017
Fix #3457: Timeout when fetching source data from NicoSeiga.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant