Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrentUser.ip_addr isn't set for anonymous users. #3464

Closed
evazion opened this issue Dec 27, 2017 · 0 comments · Fixed by #3465
Closed

CurrentUser.ip_addr isn't set for anonymous users. #3464

evazion opened this issue Dec 27, 2017 · 0 comments · Fixed by #3465
Labels
Bug

Comments

@evazion
Copy link
Member

evazion commented Dec 27, 2017

CurrentUser.ip_addr is nil for anonymous users. This breaks a couple things:

  • User#validate_sock_puppets doesn't actually work. Users can still register multiple accounts under the same IP.

  • User#validate_ip_addr_is_not_banned doesn't actually prevent IP banned users from registering new accounts.
@evazion evazion added the Bug label Dec 27, 2017
evazion added a commit to evazion/danbooru that referenced this issue Dec 27, 2017
@evazion
Fix danbooru#3464: CurrentUser.ip_addr isn't set for anonymous users.
ad74d9e
@evazion evazion mentioned this issue Dec 27, 2017
Merged
r888888888 added a commit that referenced this issue Dec 27, 2017
@r888888888
Merge pull request #3465 from evazion/fix-3464
12ce691 
Fix #3464: CurrentUser.ip_addr isn't set for anonymous users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3464: CurrentUser.ip_addr isn't set for anonymous users. evazion/danbooru
1 participant
@evazion