Post replacement breaks posts whose images are hosted on raikou2.donmai.us

[RaisingK]

When post replacement is done on an old post whose sample/fullsize are hosted on https://raikou2.donmai.us/, the new image is stored as new posts store images, but the post still tries to use the old https://raikou2.donmai.us/ URLs with the new MD5.

See post #872149 for one such casualty.

[evazion]

See also #3560. I haven't tested this, but I think replacing ugoiras is also broken. Ugoira thumbnails/samples are generated asynchronously during the upload process, so they may not exist yet when post replacement tries to distribute the files. I don't think replaced files can be deleted from the archive servers either.

I think it would be a good idea to introduce some kind of AssetManager abstraction for dealing with file storage. RemoteFileManager and S3BackupService would become instances of this.

[evazion]

Some WIP towards this: e38673d. The uploading process will have to be reworked a little bit, because right now it assumes uploads will be stored on the local filesystem, which is not necessarily the case.

[evazion]

More work: evazion/danbooru@master-evazion...evazion:feat-storage-manager. Nearly there, just need to finish some tests.

[RaisingK]

post #324768, post #1045226, and post #185322 (raikou# images) broke after replacement. And post #749786 may have been broken for a year.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.