Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Ambiguous/Do-not-use tag category #4562

Closed
nonamethanks opened this issue Jul 28, 2020 · 1 comment · Fixed by #5099
Closed

Suggestion: Ambiguous/Do-not-use tag category #4562

nonamethanks opened this issue Jul 28, 2020 · 1 comment · Fixed by #5099
Labels

Comments

@nonamethanks
Copy link
Member

nonamethanks commented Jul 28, 2020

This specific suggestion, among the various categories, has been proposed many times before, but I just noticed Gelbooru has it too (example), which makes a strong case for adopting it since it seems to work fine for them, so I'm opening this for consideration.
image

The category would be basically for tags that should not be used. This doesn't sound very useful at first, but there are many implications to consider: first of all the ability to use a "ambtags:>0" (or whatever it would be named) search, and then the fact that a warning could be tied to such tags so that people using them immediately notice. Also, it'd be much easier to spot such tags in the sea of blue that normal taglists can be.

This kind of category would be especially useful for things that cannot be aliased (keyboard is an example).

I know we want to avoid having a rainbow on the sidebar, but as these tags should never be used, that shouldn't be a problem, as they would effectively be handled like tagme and regularly sorted through.

And we have many of these tags. Here's a very partial list: https://danbooru.donmai.us/wiki_pages/list_of_disambiguation_pages

Feel free to immediately close this of course if it's rejected.

@BrokenEagle
Copy link
Collaborator

In addition to the points that nonamethanks brought up, the proposed new tag category would also be useful as a highlight in the wikis for tags that should or should not be in certain wikis. For example, the "list of" page that was mentioned above should just be a sea of grey, and any outliers would be instantly and clearly highlighted. Additionally, if the use of an ambiguous tag was used in any particular wiki, than that would also be highlighted for potential removal.

Another usecase could also maybe be the missed searches page, as many of the tags showing up there would be potential candidates for being made ambigous tags if they aren't already.

Also, besides using the "ambtags:>0" to find incorrectly tagged posts, the /tags endpoint could also be used for this, as it already normally only shows tags with postcounts greater than 0, and searching by the new category would bring up the full list of deprecated tags that are currently in use.

Finally, I'd also like to see the antecedents of aliases be given this category as well. As such, it would probably be better to give this category the same name as Gelbooru, i.e. "deprecated", which is more inclusive towards the aliases. This would also help highlight those cases in the wiki where an alias was left behind in a wiki without being updated to the consequent.

evazion added a commit that referenced this issue Jan 4, 2021
On the posts show page, in the favorites list, show favorites according
to the order they were added to the favorites table, rather than the
order they were added to the posts's fav_string.

On most posts these should be the same, but on old posts they may be
slightly different. The IDs of the first few hundred thousand favorites
don't appear to be in chronological order. Probably the original
favorite IDs were lost and recreated by a database move at some point in
Danbooru's history. The fav_string is also inconsistent with the
favorites table in some places (one contains favorites that aren't
contained by the other), which also throws off the order.

Partially addresses #4562 by eliminating one place where we depended on
the fav_string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants