Tumblr: support highest res for new image urls #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonamethanks
force-pushed
the
fix_tumblr
branch
from
d367a1b
to
5615719
Compare
evazion
reviewed
Aug 17, 2020
|
|
||
| candidates.find do |candidate| | ||
| http_exists?(candidate) | ||
| resp = Danbooru::Http.cache(1.minute).get(url, headers: NEW_HEADERS).parse |
There was a problem hiding this comment.
The base strategy defines a http object that should be used by source strategies instead of instantiating a new Danbooru::Http client themselves. This is so that default http settings are shared by all source strategies.
Also the user agent is already set inside Danbooru::Http#initialize.
evazion
reviewed
Aug 17, 2020
| candidates.find do |candidate| | ||
| http_exists?(candidate) | ||
| end | ||
| elsif url =~ %r{/s\d+x\d+/(\w+\.\w+)$}i |
There was a problem hiding this comment.
Regexes should use \z instead of $. See https://stackoverflow.com/a/5979643.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4502