Email notification #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings from the phpci config under the heading email_settings: smtp_address smtp_port smtp_username smtp_password and from_address
… out if the the build has succeeded or not.
… these addresses will be mailed with a pass or fail message.
Closed
swiftmailer was added automatically by PHPStorm and the indentation didn't match the rest of the file.
|
Looks good to me! What makes it a partial implementation? |
ghost
assigned 
|
The three main things that need adding are:
|
|
Ah, good call. Are we going to leave un-merged until that stuff is done? |
|
Hmmm. Hadn't really thought about it. It works (or at least should) in very simple cases so it might be worth merging now to start getting some testing of it done. I don't anticipate any major structural changes so merging now and then merging again later shouldn't affect very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements functionality for #35.
Email notifications sent to a default address registered during install and any addresses added in the phpci.yml:
complete:
email:
addresses:
- test1@gmail.com
- test2@gmail.com