Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow theme to be set via environment variables #2

Closed
dandavison opened this issue Jun 27, 2019 · 1 comment · Fixed by #49
Closed

Allow theme to be set via environment variables #2

dandavison opened this issue Jun 27, 2019 · 1 comment · Fixed by #49
Labels
enhancement New feature or request

Comments

@dandavison
Copy link
Owner

E.g. try DELTA_THEME first, then BAT_THEME.
dandavison added a commit that referenced this issue Nov 2, 2019
@dandavison
Honor BAT_THEME environment variable and refactor.
2ec9578 
Refactor setting of syntax highlighting theme and background color
mode from command line arguments.

Fixes #2
@dandavison dandavison mentioned this issue Nov 2, 2019
Merged
@dandavison
Copy link
Owner Author

It seemed supporting a DELTA_THEME env var was not necessary, given the availability of the --theme argument. See code comment for spec.

@dandavison dandavison added the enhancement New feature or request label Dec 4, 2019
@dandavison dandavison mentioned this issue Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Honor BAT_THEME env var, refactor theme selection dandavison/delta
1 participant
@dandavison