Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Themes whose names have uppercase letters are silently ignored #716

Closed
Tak opened this issue Sep 14, 2021 · 1 comment 路 Fixed by #718
Closed

馃悰 Themes whose names have uppercase letters are silently ignored #716

Tak opened this issue Sep 14, 2021 · 1 comment 路 Fixed by #718

Comments

@Tak
Copy link
Contributor

Tak commented Sep 14, 2021

If I create a theme feature in .gitconfig (or an included file) named like [delta "Tak"], it will be silently ignored (also in e.g. --show-themes)

This appears to be a result of force-lowercasing in some places for comparison and doing original-case lookups in other places.

Obviously there's an easy workaround, but it took quite a while to find out why my theme wasn't getting picked up. 馃檪

@dandavison
Copy link
Owner

Hi @Tak, oops! OK, thanks very much for the report; will fix. (Of course, if you feel like a Rust PR, go for it also!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants