Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous lowercasing of feature names #718

Merged
merged 1 commit into from Sep 15, 2021

Conversation

Tak
Copy link
Contributor

@Tak Tak commented Sep 15, 2021

Fixes #716

I'm a little apprehensive that the lowercasing was there for a reason, but all the tests are passing 馃し

@dandavison
Copy link
Owner

Thanks very much @Tak!

I'm a little apprehensive that the lowercasing was there for a reason

I've thought about it but I'm not sure why I did that. I think I may have had in mind code I'd written to do something like support "Red" and "red" as color names (which we do support), and then added that canonicalization inappropriately here. I don't see a reason why case-sensitivity of feature names will confuse people, and indeed it seems appropriate.

@dandavison dandavison merged commit b49f903 into dandavison:master Sep 15, 2021
@Tak Tak deleted the 716-respect-uppercase-features branch September 16, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃悰 Themes whose names have uppercase letters are silently ignored
2 participants