Explicitly request xz compression #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baryluk
reviewed
Dec 3, 2022
etc/ci/before_deploy.sh
Outdated
| @@ -162,7 +162,7 @@ Description: Syntax highlighter for git | |||
| detection, and restructured diff output for git on the command line. | |||
| EOF | |||
|
|
|||
| fakeroot dpkg-deb --build "$tempdir" "${dpkgname}_${version}_${architecture}.deb" | |||
| fakeroot dpkg-deb -Z xz --build "$tempdir" "${dpkgname}_${version}_${architecture}.deb" | |||
There was a problem hiding this comment.
Please use -Zxz without a space.
This is what man page says. (-Z xz works - I just tested it, but is not explicitly documented).
There was a problem hiding this comment.
OK, changed! Personally I have always inserted a space after a single-letter flag for every Unix/Linux command I've used in the last 20 years as far as I remember -- I think a Linux command would be pretty broken if it didn't accept a space. Plus one has to remember that Java and Windows people for some reason think it's acceptable to use a single - with the long option variants :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248