INFRASYS-5894 - Rolling deploy automation #4
Conversation
|
adamjkeller
changed the title
|
We should have a check for the ami currently configured in the launch configuration to make sure its "ready", to avoid issues when the ami is copying from 1 env to the other. If its pending, wait a bit. |
|
@mjgorman added ami check method to script |
|
+1 |
| elif env in ['stg', 'prd']: | ||
| return 'us-east-1' | ||
| else: | ||
| return env # This method is somewhat specific to our environment, so I am allowing the option for env to equal an actual region and will return the original value supplied |
There was a problem hiding this comment.
I would suggest moving this into a separate file/class and calling it statically.
My thinking is this will depend on who uses the application.
It should be blank and filled in by users as a configs file
|
+1 added a minor suggestion to code aesthetics, but it all looks great. Awesome job! |
| elif env in ['stg', 'prd']: | ||
| return 'us-east-1' | ||
| else: | ||
| return env # This method is somewhat specific to our environment, so I am allowing the option for env to equal an actual region and will return the original value supplied |
There was a problem hiding this comment.
@adamjkeller could we use config file for this method, so it will be useful for other people.
Also, method should return False or valid(!) AWS region name, like us-east-1
Update README.md
|
Most recent build: akeller@akeller-MBPR License2Deploy (INFRASYS-5894-AK):$ python License2Deploy/rolling_deploy.py stg dnbi-cirrus 6 'ami-e380fe86' 'dnbi-deploy' |
INFRASYS-5894 - Rolling deploy automation
Unit tests and completion of script still pending.