Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandi move: Fix resolution of nonexistent dests when in a subdirectory #1063

Merged
merged 1 commit into from Jul 15, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 15, 2022

Fixes #1057.

@jwodder jwodder added the patch Increment the patch version when merged label Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1063 (de0c82d) into master (e4dc875) will increase coverage by 0.06%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   88.35%   88.42%   +0.06%     
==========================================
  Files          72       72              
  Lines        9250     9258       +8     
==========================================
+ Hits         8173     8186      +13     
+ Misses       1077     1072       -5     
Flag Coverage Δ
unittests 88.42% <84.61%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/move.py 91.54% <66.66%> (+0.02%) ⬆️
dandi/tests/test_move.py 100.00% <100.00%> (ø)
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4dc875...de0c82d. Read the comment docs.

@yarikoptic
Copy link
Member

Didn't test but the added unittest seems to test exactly what is needed, so let's proceed. Thank you @jwodder . Let's release with this

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 15, 2022
@yarikoptic yarikoptic merged commit 1181b3f into master Jul 15, 2022
@yarikoptic yarikoptic deleted the gh-1057 branch July 15, 2022 20:40
@github-actions
Copy link

🚀 PR was released in 0.45.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-move patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move command should take destination as a relative path too for local operation
2 participants