Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#399 #416 Initial fix for header/footer showing on page without body rows #418

Open
wants to merge 6 commits into
base: open-dev-v1
Choose a base branch
from
Open

#399 #416 Initial fix for header/footer showing on page without body rows #418

wants to merge 6 commits into from

Commits on Nov 23, 2019

  1. #399 #416 Initial fix for header/footer showing on a page with no bod… 

    …y rows.

With test proof.
    @danfickle
    danfickle committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    3aa60aa View commit details
    Browse the repository at this point in the history

  2. Compiler fixes for newtable package. [ci skip] 

    + Remove unneeded casts.
+ Add override annotations.
+ Change anonymous class creation to lambda (manual).
    @danfickle
    danfickle committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    26116a6 View commit details
    Browse the repository at this point in the history

  3. #202 #399 Failing test for table with too high first body row. [ci skip] 

    Plus orphaned thead.

Also compiler fixes for ContentLimit/ContentLimitContainer.

Test based on the one provided by @jesselong. Thanks.
    @danfickle
    danfickle committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    0cf6160 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Merge branch 'open-dev-v1' into fix_399_empty_table_header_footer

    @danfickle
    danfickle committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    0f66dcf View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. #202 - Correct rendering for example. 

    Need more testing before we can merge this branch.
Specifically:
Cells with margin/border/padding.
Cells which go over two or more pages.
    @danfickle
    danfickle committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    dce1cd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. #202 Two more paged table tests with partial revert to make them pass. 

    Partial revert of dce1cd5 to get paged table with cells with large padding/border rendering correctly.

Unfortunately, this means that the #202 test with explicitly allowing page breaks in thead now fails again.

Fortunately, very few users want a page break in their thead so this is low priority to fix.
    @danfickle
    danfickle committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    1eba5cd View commit details
    Browse the repository at this point in the history