Update release 4.0 #1004
Merged
Update release 4.0 #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak documentation to reflect the simplified functionality, and include parameter names in examples
Added compatibility for BIP data format of hsi images in read_image
Update installation.md
Co-authored-by: Noah Fahlgren <noahfahlgren@gmail.com>
…e-update Morphology segment combine update
Threw error when img was just black (only zeros) and broke workflows
…on name This commit updates the requirements.txt file and replaces the use of the deprecated function name 'greycomatrix' with 'graycomatrix' in `threshold_methods.py`. The change in function name in skimage.feature from version 0.19 caused an ImportError when importing plantcv, which is resolved with this commit.
In skimage>=0.19, the `peak_local_max` function no longer takes the `indices` argument. This adds two lines to compute the indices after getting the local max coordinates.
Fix ImportError in plantcv caused by change in skimage.feature function name
Fixed check for binary image
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1004 +/- ##
===============================================
- Coverage 100.00% 99.98% -0.02%
===============================================
Files 147 161 +14
Lines 6640 6849 +209
===============================================
+ Hits 6640 6848 +208
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update the release_4.0 branch to pull down changes regarding python and scikit image versions. (#998 )
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md