Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel scatter visualization #810

Merged
merged 37 commits into from
Jan 26, 2022
Merged

Pixel scatter visualization #810

merged 37 commits into from
Jan 26, 2022

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Aug 4, 2021 •
edited

Describe your changes
Added the pixel scatter visualization that plots the pixels in one or more color images in a 2D plane formed by the specified channels.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Discussion #724

Additional context

@JorgeGtz JorgeGtz added new feature New feature ideas and solutions work in progress Mark work in progress labels Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited

Codecov Report

Merging #810 (0d6c946) into 4.x (4927039) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       155    +1     
  Lines         6507      6550   +43     
=========================================
+ Hits          6507      6550   +43
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/io/read_dataset.py 100.00% <ø> (ø)
plantcv/plantcv/visualize/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/pixel_scatter_vis.py 100.00% <100.00%> (ø)

@JorgeGtz JorgeGtz mentioned this pull request Sep 15, 2021
Merged
@JorgeGtz JorgeGtz mentioned this pull request Nov 29, 2021
Merged
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jan 11, 2022
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Jan 11, 2022
@nfahlgren nfahlgren changed the base branch from master to 4.x January 24, 2022 16:18
@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Jan 24, 2022
@HaleySchuhl HaleySchuhl self-requested a review January 25, 2022 15:41
nfahlgren
nfahlgren reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions

tests/plantcv/visualize/test_pixel_scatter_plot.py Outdated Show resolved Hide resolved
tests/plantcv/visualize/test_pixel_scatter_plot.py Outdated Show resolved Hide resolved
@HaleySchuhl @nfahlgren
Update test name
4b8a43a 
Co-authored-by: Noah Fahlgren <noahfahlgren@gmail.com>
@nfahlgren nfahlgren merged commit 562a80f into 4.x Jan 26, 2022
PlantCV4 automation moved this from Pull Requests to Done Jan 26, 2022
@nfahlgren nfahlgren deleted the pixel-scatter-visualization branch January 26, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees

@JorgeGtz JorgeGtz

Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Milestone
PlantCV v4.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JorgeGtz @nfahlgren @HaleySchuhl