Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two io functions #823

Merged
merged 17 commits into from
Jan 18, 2022
Merged

Two io functions #823

merged 17 commits into from
Jan 18, 2022

Conversation

JorgeGtz
Copy link
Contributor

Describe your changes
Started the subpackage I/O with two functions that were useful for the pixel scatter visualization:

  • read_dataset - Returns a list of paths to the images in a given directory.
  • random_subset - Returns a subset of the elements in a list.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Discussion #724 and PR #810

Additional context

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #823 (40e05ee) into 4.x (2c249a4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #823   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       154    +3     
  Lines         6527      6556   +29     
=========================================
+ Hits          6527      6556   +29     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/__init__.py 100.00% <ø> (ø)
plantcv/plantcv/io/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/io/random_subset.py 100.00% <100.00%> (ø)
plantcv/plantcv/io/read_dataset.py 100.00% <100.00%> (ø)
plantcv/__init__.py 100.00% <0.00%> (ø)

@JorgeGtz JorgeGtz added new feature New feature ideas and solutions ready to review labels Sep 15, 2021
@HaleySchuhl HaleySchuhl self-requested a review October 19, 2021 15:09
@nfahlgren
Copy link
Member

@JorgeGtz and @HaleySchuhl, not to overly complicate things, but what do you think about using the pcv.io.read_dataset method here in the timelapse video function in #762? That would just mean we would need to get this merged first and then refactor #762 somewhat.

@JorgeGtz
Copy link
Contributor Author

JorgeGtz commented Jan 4, 2022

@nfahlgren I can do the refactoring of #762 after this is merged.

@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Jan 11, 2022
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Jan 11, 2022
@HaleySchuhl HaleySchuhl self-assigned this Jan 11, 2022
@HaleySchuhl HaleySchuhl changed the base branch from master to 4.x January 18, 2022 17:21
@nfahlgren nfahlgren merged commit 010b196 into 4.x Jan 18, 2022
PlantCV4 automation moved this from Pull Requests to Done Jan 18, 2022
@nfahlgren nfahlgren deleted the two-io-functions branch January 18, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants