Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color correction #829

Merged
merged 10 commits into from
Nov 4, 2021
Merged

Update color correction #829

merged 10 commits into from
Nov 4, 2021

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Nov 3, 2021

Describe your changes
Cast the source and target images as float64 and normalize between 0-1 (the normalization is not essential).
This should avoid creating artifacts in the images due to integer overflow.

Type of update
Is this a:

  • Bug fix

Associated issues
#828

Additional context

@JorgeGtz JorgeGtz added the work in progress Mark work in progress label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #829 (4680a34) into master (4d69e78) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6218      6221    +3     
=========================================
+ Hits          6218      6221    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)

@JorgeGtz JorgeGtz added bugfix Bug fixes ready to review and removed work in progress Mark work in progress labels Nov 4, 2021
@nfahlgren nfahlgren linked an issue Nov 4, 2021 that may be closed by this pull request
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JorgeGtz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors are not real after applying correction
2 participants