cast contour tuple as a list in find_objects #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6217 6218 +1
=========================================
+ Hits 6217 6218 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JorgeGtz
added
ready to review
and removed
work in progress
nfahlgren
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Cast the contours output from cv2.findContours as a list (they now are given as a tuple)
Type of update
Is this a:
Associated issues
Additional context
Some morphology tests failed in the unrelated PR #829.
The problem seems to be that in the version of OpenCV used by the tests in GitHub (3.4.16.57) the contours in findContours
are given as a tuple instead of as a list. Those tests pass locally using OpenCV 3.4.14.