Allow passing in the contents of a dangerfile - incase you're working…

… in-memory, like peril does

source/commands/danger-pr.ts

@@ -72,7 +72,7 @@ async function runDanger(source: FakeCI, platform: GitHub, file: string) {
   const exec = new Executor(source, platform, config)
 
   const runtimeEnv = await exec.setupDanger()
-  const results = await runDangerfileEnvironment(file, runtimeEnv)
+  const results = await runDangerfileEnvironment(file, undefined, runtimeEnv)
   if (program["repl"]) {
     openRepl(runtimeEnv.sandbox)
   } else {

source/runner/DangerfileRunner.ts

@@ -70,11 +70,15 @@ export type TranspileType = null | "babel" | "typescript"
  * @param {any} environment the results of createDangerfileRuntimeEnvironment
  * @returns {DangerResults} the results of the run
  */
-export async function runDangerfileEnvironment(filename: string, environment: NodeVMOptions): Promise<DangerResults> {
+export async function runDangerfileEnvironment(
+  filename: string,
+  originalContents: string | undefined,
+  environment: NodeVMOptions
+): Promise<DangerResults> {
   const vm = new NodeVM(environment)
 
   // Require our dangerfile
-  const originalContents = fs.readFileSync(filename, "utf8")
+  originalContents = originalContents || fs.readFileSync(filename, "utf8")
   let content = cleanDangerfile(originalContents)
 
   // TODO: Relative imports get TS/Babel

source/runner/Executor.ts

@@ -62,7 +62,7 @@ export class Executor {
     // If an eval of the Dangerfile fails, we should generate a
     // message that can go back to the CI
     try {
-      results = await runDangerfileEnvironment(file, runtime)
+      results = await runDangerfileEnvironment(file, undefined, runtime)
     } catch (error) {
       results = this.resultsForError(error)
     }

source/runner/_tests/_danger_runner.test.ts

@@ -35,7 +35,7 @@ describe("with fixtures", () => {
   it("handles a blank Dangerfile", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileEmpty.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileEmpty.js"), undefined, runtime)
 
     expect(results).toEqual({
       fails: [],
@@ -48,7 +48,7 @@ describe("with fixtures", () => {
   it("handles a full set of messages", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileFullMessages.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileFullMessages.js"), undefined, runtime)
 
     expect(results).toEqual({
       fails: [{ message: "this is a failure" }],
@@ -63,7 +63,7 @@ describe("with fixtures", () => {
     const runtime = await createDangerfileRuntimeEnvironment(context)
 
     try {
-      await runDangerfileEnvironment(resolve(fixtures, "__DangerfileBadSyntax.js"), runtime)
+      await runDangerfileEnvironment(resolve(fixtures, "__DangerfileBadSyntax.js"), undefined, runtime)
       throw new Error("Do not get to this")
     } catch (e) {
       // expect(e.message === ("Do not get to this")).toBeFalsy()
@@ -74,13 +74,13 @@ describe("with fixtures", () => {
   it.skip("handles relative imports correctly in Babel", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    await runDangerfileEnvironment(resolve(fixtures, "__DangerfileImportRelative.js"), runtime)
+    await runDangerfileEnvironment(resolve(fixtures, "__DangerfileImportRelative.js"), undefined, runtime)
   })
 
   it("handles scheduled (async) code", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileScheduled.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileScheduled.js"), undefined, runtime)
     expect(results).toEqual({
       fails: [],
       messages: [],
@@ -92,7 +92,11 @@ describe("with fixtures", () => {
   it("handles multiple scheduled statements and all message types", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileMultiScheduled.js"), runtime)
+    const results = await runDangerfileEnvironment(
+      resolve(fixtures, "__DangerfileMultiScheduled.js"),
+      undefined,
+      runtime
+    )
     expect(results).toEqual({
       fails: [{ message: "Asynchronous Failure" }],
       messages: [{ message: "Asynchronous Message" }],
@@ -104,7 +108,7 @@ describe("with fixtures", () => {
   it("in Typescript it handles multiple scheduled statements and all message types", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.ts"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.ts"), undefined, runtime)
     expect(results.warnings).toEqual([
       {
         message: "Async Function",
@@ -119,7 +123,7 @@ describe("with fixtures", () => {
     // this test takes *forever* because of babel-polyfill being required
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.js"), undefined, runtime)
     expect(results.warnings).toEqual([
       {
         message: "Async Function",
@@ -134,7 +138,7 @@ describe("with fixtures", () => {
     // this test takes *forever* because of babel-polyfill being required
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.ts"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileAsync.ts"), undefined, runtime)
     expect(results.warnings).toEqual([
       {
         message: "Async Function",
@@ -148,7 +152,7 @@ describe("with fixtures", () => {
   it("can schedule callback-based promised ", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileCallback.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileCallback.js"), undefined, runtime)
     expect(results.warnings).toEqual([
       {
         message: "Scheduled a callback",
@@ -159,7 +163,7 @@ describe("with fixtures", () => {
   it("can handle TypeScript based Dangerfiles", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileTypeScript.ts"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfileTypeScript.ts"), undefined, runtime)
     expect(results.messages).toEqual([
       {
         message: "Honey, we got Types",
@@ -170,7 +174,7 @@ describe("with fixtures", () => {
   it("can handle a plugin (which is already used in Danger)", async () => {
     const context = await setupDangerfileContext()
     const runtime = await createDangerfileRuntimeEnvironment(context)
-    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfilePlugin.js"), runtime)
+    const results = await runDangerfileEnvironment(resolve(fixtures, "__DangerfilePlugin.js"), undefined, runtime)
 
     expect(results.fails[0].message).toContain("@types dependencies were added to package.json")
   })