Make green

danger · Nov 12, 2018 · 2989fdc · 2989fdc
1 parent 8c40e40
commit 2989fdc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,7 +14,8 @@
 ## Master
 
 - Improves debug logging, messaging on CI about status updates - [@orta][]
-- Better detection of json results: {} from a sub-process- [@orta][]
+- Better detection of json results: {} from a sub-process - [@orta][]
+- CLI Args are actually passed to subprocess instead of an empty object - [@orta][]
 
 # 6.1.0
 

diff --git a/source/platforms/github/_tests/_github_api.test.ts b/source/platforms/github/_tests/_github_api.test.ts
@@ -162,7 +162,7 @@ describe("API testing", () => {
         method: "POST",
         body: '{"state":"pending","context":"Danger","target_url":"http://danger.systems/js","description":"message"}',
       },
-      undefined
+      true
     )
   })
 
@@ -181,7 +181,7 @@ describe("API testing", () => {
         method: "POST",
         body: '{"state":"failure","context":"Danger","target_url":"http://danger.systems/js","description":"message"}',
       },
-      undefined
+      true
     )
   })
 
@@ -200,7 +200,7 @@ describe("API testing", () => {
         method: "POST",
         body: '{"state":"success","context":"Danger","target_url":"http://example.org","description":"message"}',
       },
-      undefined
+      true
     )
   })
 
@@ -219,7 +219,7 @@ describe("API testing", () => {
         method: "POST",
         body: '{"state":"success","context":"Danger","target_url":"http://danger.systems/js","description":"message"}',
       },
-      undefined
+      true
     )
   })
 

diff --git a/source/runner/_tests/_executor.test.ts b/source/runner/_tests/_executor.test.ts
@@ -29,7 +29,7 @@ const defaultConfig = {
 const fakeCI = new FakeCI({})
 
 const defaultDsl = (platform: any): Promise<DangerDSLType> => {
-  return jsonDSLGenerator(platform, fakeCI).then(jsonDSL => {
+  return jsonDSLGenerator(platform, fakeCI, {} as any).then(jsonDSL => {
     jsonDSL.github = {
       pr: {
         number: 1,

diff --git a/source/runner/runners/_tests/vm2.test.ts b/source/runner/runners/_tests/vm2.test.ts
@@ -48,7 +48,7 @@ runners.forEach(run => {
       const source = new FakeCI({})
       exec = new Executor(source, platform, run.fn, config)
 
-      const dsl = await jsonDSLGenerator(platform, new FakeCI({}))
+      const dsl = await jsonDSLGenerator(platform, new FakeCI({}), {} as any)
       dsl.github = {
         pr: {
           number: 1,