Some process faffing

danger · Jan 6, 2018 · 79aaec0 · 79aaec0
1 parent b2b8d06
commit 79aaec0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/commands/danger.ts b/source/commands/danger.ts
@@ -34,7 +34,9 @@ program
 
 program.parse(process.argv)
 
-const showUpgradeNotice = process.env.CI && ['init', 'ci', 'process', 'pr', '--help'].some(cmd => process.argv.includes(cmd))
+const showUpgradeNotice =
+  process.env.CI && ["init", "ci", "process", "pr", "--help"].some(cmd => process.argv.includes(cmd))
+
 if (showUpgradeNotice) {
   console.error("You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.")
 }
diff --git a/source/runner/Executor.ts b/source/runner/Executor.ts
@@ -111,8 +111,6 @@ export class Executor {
    */
   async handleResultsPostingToSTDOUT(results: DangerResults) {
     const { fails, warnings, messages, markdowns } = results
-    process.exitCode = fails.length > 0 ? 1 : 0
-
     if (this.options.jsonOnly) {
       // Format for Danger Process
       const results = {