clean up code using @orta's suggestions

danger · Feb 21, 2017 · a70cc3e · a70cc3e
1 parent b8cc328
commit a70cc3e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/source/runner/Dangerfile.ts b/source/runner/Dangerfile.ts
@@ -70,10 +70,7 @@ export function contextForDanger(dsl: DangerDSLType): DangerContext {
     scheduled: []
   }
 
-  const schedule = (fn: Function) => {
-    console.log("scheduling task", fn)
-    results.scheduled.push(fn)
-  }
+  const schedule = (fn: Function) => results.scheduled.push(fn)
   const fail = (message: MarkdownString) =>  results.fails.push({ message })
   const warn = (message: MarkdownString) => results.warnings.push({ message })
   const message = (message: MarkdownString) => results.messages.push({ message })

diff --git a/source/runner/DangerfileRunner.ts b/source/runner/DangerfileRunner.ts
@@ -73,7 +73,9 @@ export async function runDangerfileEnvironment(filename: Path, environment: Dang
     runtime.requireModule(filename)
   })
 
-  return environment.context.results
+  const results = environment.context.results
+  await Promise.all(results.scheduled)
+  return results
 }
 
 /**

diff --git a/source/runner/Executor.ts b/source/runner/Executor.ts
@@ -62,9 +62,6 @@ export class Executor {
    * @returns {void} It's a promise, so a void promise
    */
   async handleResults(results: DangerResults) {
-    // run the asynchronous code first
-    console.log("handling scheduled tasks", results.scheduled)
-    await Promise.all(results.scheduled)
     // Ensure process fails if there are fails
     if (results.fails.length) {
       process.exitCode = 1