Skip to content

Commit

Permalink
Merge pull request #5 from danger/commands
Browse files Browse the repository at this point in the history
Initial structure for the Travis  CI Souce
  • Loading branch information
orta committed Oct 1, 2016
2 parents a466c65 + b32cf0d commit a7bee2e
Show file tree
Hide file tree
Showing 14 changed files with 428 additions and 41 deletions.
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"presets": [
"es2016"
"es2015"
],
"plugins": ["transform-flow-strip-types"]
}
10 changes: 9 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"env": {
"es6": true,
"jest": true
},
"parser": "babel-eslint",
"extends": "standard",
"plugins": [
Expand All @@ -7,8 +11,9 @@
"flowtype",
"flow-vars"
],
"presets": ["es2015", "react"],
"presets": ["es2015"],
"rules": {
"space-before-function-paren": ["error", "never"],
"quotes": [1, "double", "avoid-escape"],
"flowtype/define-flow-type": 1,
"flowtype/require-parameter-type": 1,
Expand All @@ -19,6 +24,9 @@
"flowtype/use-flow-type": 1,
"flowtype/valid-syntax": 1
},
"ignore": [
"distribution"
],
"settings": {
"flowtype": {
"onlyFilesWithFlowAnnotation": false
Expand Down
3 changes: 3 additions & 0 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@ distribution
[include]

[libs]
interfaces/
flow-typed/

[options]
unsafe.enable_getters_and_setters=true
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ jspm_packages
.node_repl_history

distribution
typings
flow-typed
15 changes: 11 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,18 @@ npm run flow

---

You'll have a nicer experience as a developer if you use VS Code with Flow enabled, and if you install typings.
### Dev Life

You'll have a nicer experience as a developer if you use VS Code with Flow enabled, and if you install flow-typed.

``` sh
npm install -g typings
typings install
```
npm install -g flow-typed
flow-typed install
```

( and maybe `flow-typed install jest@14`)

You can run the `danger` command globally from your dev build by running `npm link`.

### What is the TODO?

Expand All @@ -38,3 +44,4 @@ typings install
* A way to do git.diff metadata see [EnvironmentManager](https://github.com/danger/danger/blob/c7880ebd870407e9effa1bb4295540d1fa6b4bbc/lib/danger/danger_core/environment_manager.rb) for setup, needs to get info from request source

The aim is to be able to have this library self testing with Danger-js ASAP, then smarter abstractions can be thought about.

238 changes: 218 additions & 20 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a7bee2e

Please sign in to comment.