Merge pull request #908 from danger/bitrise_commit_hash

Take commit hash from bitrise env
danger · Aug 8, 2019 · beac295 · beac295
2 parents b5c0919 + 2d2c935
commit beac295
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,8 @@
 
 <!-- Your comment below this -->
 
+- Take commit hash from bitrise env - [@f-meloni]
+
 # 9.1.4
 
 - Use new env `BITBUCKET_REPO_FULL_NAME` in bitbucket pipeline. - [@Soyn]

diff --git a/source/ci_source/providers/Bitrise.ts b/source/ci_source/providers/Bitrise.ts
@@ -72,6 +72,10 @@ export class Bitrise implements CISource {
   }
 
   get ciRunURL() {
-    return process.env.BITRISE_PULL_REQUEST
+    return this.env.BITRISE_PULL_REQUEST
+  }
+
+  get commitHash() {
+    return this.env.BITRISE_GIT_COMMIT
   }
 }
diff --git a/source/ci_source/providers/_tests/_bitrise.test.ts b/source/ci_source/providers/_tests/_bitrise.test.ts
@@ -73,3 +73,19 @@ describe(".repoSlug", () => {
     expect(bitrise.repoSlug).toEqual("artsy/eigen")
   })
 })
+
+describe("commit hash", () => {
+  it("returns correct commit hash when present", () => {
+    const env = {
+      ...correctEnv,
+      BITRISE_GIT_COMMIT: "1234abc",
+    }
+    const bitrise = new Bitrise(env)
+    expect(bitrise.commitHash).toEqual("1234abc")
+  })
+
+  it("returns no commit hash when not present", () => {
+    const bitrise = new Bitrise(correctEnv)
+    expect(bitrise.commitHash).toBeUndefined()
+  })
+})