More octokit stuff

source/platforms/github/GitHubAPI.ts

@@ -42,7 +42,7 @@ export class GitHubAPI {
    * I wouldn't have a problem with moving this to use this API under the hood
    * but for now that's just a refactor someone can try.
    */
-  getExternalAPI = (JWTForGithubApp?: string): GitHubNodeAPI => {
+  getExternalAPI = (accessTokenForApp?: string): GitHubNodeAPI => {
     const host = process.env["DANGER_GITHUB_API_BASE_URL"] || undefined
     const options: GitHubNodeAPI.Options & { debug: boolean } = {
       debug: !!process.env.LOG_FETCH_REQUESTS,
@@ -51,14 +51,12 @@ export class GitHubAPI {
         ...this.additionalHeaders,
       },
     }
+    // A token should have been set by this point
+    const token = accessTokenForApp || this.token!
+
     const api = new GitHubNodeAPI(options)
+    api.authenticate({ type: "token", token: token })
 
-    if (JWTForGithubApp) {
-      // I sent a PR for this: https://github.com/octokit/rest.js/pull/873
-      api.authenticate({ type: "app", token: JWTForGithubApp } as any)
-    } else if (this.token) {
-      api.authenticate({ type: "token", token: this.token })
-    }
     return api
   }