When you have empty results, return empty results so that danger dele…

…tes the comment
danger · Jul 21, 2018 · e1ee7ca · e1ee7ca
1 parent c71c297
commit e1ee7ca
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/source/platforms/github/comms/checksCommenter.ts b/source/platforms/github/comms/checksCommenter.ts
@@ -1,5 +1,5 @@
 import { GitHubAPI } from "../GitHubAPI"
-import { DangerResults } from "../../../dsl/DangerResults"
+import { DangerResults, isEmptyResults, emptyResults } from "../../../dsl/DangerResults"
 import { ExecutorOptions } from "../../../runner/Executor"
 import { resultsToCheck } from "./checks/resultsToCheck"
 import { getAccessTokenForInstallation } from "./checks/githubAppSupport"
@@ -92,19 +92,22 @@ export const GitHubChecksCommenter = (api: GitHubAPI) => {
   }
 }
 
-export const tweetSizedResultsFromResults = (results: DangerResults, checksResponse: any): DangerResults => ({
-  warnings: [],
-  messages: [],
-  fails: [],
-  markdowns: [
-    {
-      message:
-        "Danger run resulted in " +
-        messageFromResults(results) +
-        `; to find out more, see the [checks page](${checksResponse.html_url}).`,
-    },
-  ],
-})
+export const tweetSizedResultsFromResults = (results: DangerResults, checksResponse: any): DangerResults =>
+  isEmptyResults(results)
+    ? emptyResults()
+    : {
+        warnings: [],
+        messages: [],
+        fails: [],
+        markdowns: [
+          {
+            message:
+              "Danger run resulted in " +
+              messageFromResults(results) +
+              `; to find out more, see the [checks page](${checksResponse.html_url}).`,
+          },
+        ],
+      }
 
 const messageFromResults = (results: DangerResults): string => {
   const appendS = (arr: any[]) => (arr.length === 1 ? "" : "s")