Blocks PRs which change the package version, and moves the integratio…

…n tests to node 10 now that the github package has a minimum of 10
danger · Sep 7, 2019 · fafd24c · fafd24c
1 parent 5ea8884
commit fafd24c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -67,7 +67,7 @@ matrix:
           source/platforms/git/_tests/local_dangerfile_example.ts || echo "Skipping Danger Local for non PR run"'
 
     # Create some fake projects at runtime
-    - node_js: "8"
+    - node_js: "10.12"
       script:
         - echo "This is only for Integration tests on two blank projects"
         - yarn build

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,9 @@
 
 ## Master
 
-<!-- Your comment below this -->
+<!-- Your comment between this -->
+
+<!-- Your comment above this -->
 
 # 9.1.4
 

diff --git a/dangerfile.ts b/dangerfile.ts
@@ -38,6 +38,12 @@ export default async () => {
   // Some libraries
   await yarn()
   await jest()
+
+  // Don't have folks setting the package json version
+  const packageDiff = await danger.git.JSONDiffForFile("package.json")
+  if (packageDiff.version && danger.github.pr.user.login !== "orta") {
+    fail("Please don't make package version changes")
+  }
 }
 
 // Re-run the git push hooks