Merge pull request #1092 from JanStevens/patch-1

Use markdown styled icons instead of unicode chars
danger · Jan 4, 2021 · fccf835 · fccf835
2 parents 3a90dec + 79764c5
commit fccf835
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 53 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 
 <!-- Your comment below this -->
 
+- Bitbucket Cloud: Add markdown emoji instead of unicode [@JanStevens]
 - Add `DANGER_DISABLE_TSC` environment variable to disable transpiling with tsc, providing a way to force transpiling
   with Babel - [@ozzieorca]
 - Adds options `--newComment` and `--removePreviousComments` - [@davidhouweling]

diff --git a/source/runner/templates/_tests/__snapshots__/_bitbucketCloudTemplate.test.ts.snap b/source/runner/templates/_tests/__snapshots__/_bitbucketCloudTemplate.test.ts.snap
@@ -4,16 +4,16 @@ exports[`generating inline messages summary inline result matches snapshot 1`] =
 "
 [//]: # (danger-id-blankID;)
 [//]: # (  File: File.swift;Line: 5;)
-- ❌ Failing message Failing message
-- ⚠️ Warning message Warning message
-- ✨ message
+- :x: Failing message Failing message
+- :warning: Warning message Warning message
+- :sparkles: message
 markdown
   "
 `;
 
 exports[`generating messages for BitBucket cloud Mixed icon messages match snapshot 1`] = `
 "
-  🎉  All green. Well done.
+  :tada:  All green. Well done.
 
   
   
@@ -23,151 +23,151 @@ exports[`generating messages for BitBucket cloud Mixed icon messages match snaps
   | --- |
   | 📝 - Message with custom icon |
   | 🔔 - Message with custom icon2 |
-  | ✨ - Test message |
+  | :sparkles: - Test message |
 
   
-  
-  
-  
+
   
 
-  Generated by 🚫 [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
+  Generated by :no_entry_sign: [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
   [](http://danger-id-blankID;)
   "
 `;
 
 exports[`generating messages for BitBucket cloud empty result matches snapshot, with a compliment 1`] = `
 "
-  🎉  All green. Well done.
+  :tada:  All green. Well done.
 
   
   
   
-  
-  
-  
+
   
 
-  Generated by 🚫 [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
+  Generated by :no_entry_sign: [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
   [](http://danger-id-blankID;)
   "
 `;
 
 exports[`generating messages for BitBucket cloud multiple summary result matches snapshot 1`] = `
 "
-  ⚠️  Danger found some issues. Don't worry, everything is fixable.
+  :warning:  Danger found some issues. Don't worry, everything is fixable.
 
   
 
   |      2 Fails |
   | --- |
-  | ❌ - Failing message Failing message |
-  | ❌ - Failing message 2, This is Failing message |
+  | :x: - Failing message Failing message |
+  | :x: - Failing message 2, This is Failing message |
 
   
   
 
   |      2 Warnings |
   | --- |
-  | ⚠️ - Warning message Warning message |
-  | ⚠️ - Warning message |
+  | :warning: - Warning message Warning message |
+  | :warning: - Warning message |
 
   
   
 
   |      3 Messages |
   | --- |
-  | ✨ - message |
-  | ✨ - message 2 |
-  | ✨ - message 3 |
+  | :sparkles: - message |
+  | :sparkles: - message 2 |
+  | :sparkles: - message 3 |
 
   
-  
+
   markdown
-  
-  
 
-  Generated by 🚫 [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
+  Generated by :no_entry_sign: [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
   [](http://danger-id-blankID;)
   "
 `;
 
 exports[`generating messages for BitBucket cloud summary result matches snapshot, with a commit 1`] = `
 "
-  ⚠️  Danger found some issues. Don't worry, everything is fixable.
+  :warning:  Danger found some issues. Don't worry, everything is fixable.
 
   
 
   |      1 Fails |
   | --- |
-  | ❌ - Failing message Failing message |
+  | :x: - Failing message Failing message |
 
   
   
 
   |      1 Warnings |
   | --- |
-  | ⚠️ - Warning message Warning message |
+  | :warning: - Warning message Warning message |
 
   
   
 
   |      1 Messages |
   | --- |
-  | ✨ - message |
+  | :sparkles: - message |
 
   
-  
+
   markdown
-  
-  
 
-  Generated by 🚫 [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
+  Generated by :no_entry_sign: [dangerJS](https://danger.systems/js) against e70f3d6468f61a4bef68c9e6eaba9166b096e23c
   
+
   [](http://danger-id-blankID;)
   "
 `;
 
 exports[`generating messages for BitBucket cloud summary result matches snapshot, without a commit 1`] = `
 "
-  ⚠️  Danger found some issues. Don't worry, everything is fixable.
+  :warning:  Danger found some issues. Don't worry, everything is fixable.
 
   
 
   |      1 Fails |
   | --- |
-  | ❌ - Failing message Failing message |
+  | :x: - Failing message Failing message |
 
   
   
 
   |      1 Warnings |
   | --- |
-  | ⚠️ - Warning message Warning message |
+  | :warning: - Warning message Warning message |
 
   
   
 
   |      1 Messages |
   | --- |
-  | ✨ - message |
+  | :sparkles: - message |
 
   
-  
+
   markdown
-  
-  
 
-  Generated by 🚫 [dangerJS](https://danger.systems/js)
   
+
+  Generated by :no_entry_sign: [dangerJS](https://danger.systems/js)
   
+
   [](http://danger-id-blankID;)
   "
 `;
diff --git a/source/runner/templates/_tests/_bitbucketCloudTemplate.test.ts b/source/runner/templates/_tests/_bitbucketCloudTemplate.test.ts
@@ -16,9 +16,9 @@ import * as utils from "../../DangerUtils"
 
 const commitID = "e70f3d6468f61a4bef68c9e6eaba9166b096e23c"
 
-const noEntryEmoji = "❌"
-const warningEmoji = "⚠️"
-const messageEmoji = "✨"
+const noEntryEmoji = ":x:"
+const warningEmoji = ":warning:"
+const messageEmoji = ":sparkles:"
 
 describe("generating messages for BitBucket cloud", () => {
   let complimentMock: jest.Mock<string, []>

diff --git a/source/runner/templates/bitbucketCloudTemplate.ts b/source/runner/templates/bitbucketCloudTemplate.ts
@@ -3,11 +3,11 @@ import { Violation } from "../../dsl/Violation"
 import { compliment } from "../DangerUtils"
 
 // BitBucket Cloud supports these emojis 🎉
-const noEntryEmoji = "❌"
-const warningEmoji = "⚠️"
-const messageEmoji = "✨"
-const signatureEmoji = "🚫"
-const successEmoji = "🎉"
+const noEntryEmoji = ":x:"
+const warningEmoji = ":warning:"
+const messageEmoji = ":sparkles:"
+const signatureEmoji = ":no_entry_sign:"
+const successEmoji = ":tada:"
 
 export const dangerSignature = (results: DangerResults) => {
   let meta = results.meta || { runtimeName: "dangerJS", runtimeHref: "https://danger.systems/js" }
@@ -65,11 +65,11 @@ export function template(dangerID: string, results: DangerResults, commitID?: st
   ${buildMarkdownTable("Fails", noEntryEmoji, results.fails)}
   ${buildMarkdownTable("Warnings", warningEmoji, results.warnings)}
   ${buildMarkdownTable("Messages", messageEmoji, results.messages)}
-  
+
   ${results.markdowns.map(v => v.message).join("\n\n")}
-  
+
   ${dangerSignaturePostfix(results, commitID)}
-  
+
   [](http://${dangerIDToString(dangerID)})
   `
 }