Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance][Github] @octokit/rest is on version 18, but DangerJS is on 16 #1202

Closed
fbartho opened this issue Jan 25, 2022 · 2 comments · Fixed by #1204
Closed

[Maintenance][Github] @octokit/rest is on version 18, but DangerJS is on 16 #1202

fbartho opened this issue Jan 25, 2022 · 2 comments · Fixed by #1204
Labels
greenkeeper help wanted [platform] GitHub You Can Do This This idea is well spec'd and ready for a PR

Comments

@fbartho
Copy link
Member

fbartho commented Jan 25, 2022

Describe the bug
@octokit/rest is on version 18.12.0, but DangerJS is referencing Octokit 16

Expected behavior
For maintenance reasons, we should upgrade DangerJS to the 18.x API line, but this is a breaking change for DangerJS consumers, and potentially for plugins

@orta is this something we're ready to do, or do we need to hold off for some reason?
@fbartho fbartho added bug help wanted You Can Do This This idea is well spec'd and ready for a PR labels Jan 25, 2022
@fbartho
Copy link
Member Author

fbartho commented Jan 25, 2022

https://github.com/octokit/rest.js/

@orta
Copy link
Member

orta commented Jan 29, 2022

I don't go out of my way to update this sort of thing, other folks are welcome to do it 👍🏻

This was referenced Feb 1, 2022
Merged
Merged
@orta orta closed this as completed in #1204 Feb 1, 2022
orta added a commit that referenced this issue Feb 1, 2022
@orta
Merge pull request #1204 from danger/fb/bump-octokit-rest
fff2201 
Upgrade @octokit/rest from v16.43.1 to v18.12.0 - Fixes #1202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
greenkeeper help wanted [platform] GitHub You Can Do This This idea is well spec'd and ready for a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade @octokit/rest from v16.43.1 to v18.12.0 - Fixes #1202 danger/danger-js
2 participants
@orta @fbartho