Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prs.find is not a function #181

Closed
deecewan opened this issue Mar 19, 2017 · 3 comments · Fixed by #186
Closed

prs.find is not a function #181

deecewan opened this issue Mar 19, 2017 · 3 comments · Fixed by #186
Assignees
Labels

Comments

@deecewan
Copy link
Member

Just updated to the latest danger (0.13.0) and looks like something isn't quite right.

I'm not sure exactly when this call was made, but I am using Codeship. This may have something to do with API changes that the codeship provider relied on.

yarn danger v0.21.3
$ danger 
Error:  TypeError: prs.find is not a function
at Object.<anonymous> (<project>/node_modules/danger/distribution/ci_source/ci_source_helpers.js:90:39)
at step (<project>/node_modules/danger/distribution/ci_source/ci_source_helpers.js:32:23)
at Object.next (<project>/node_modules/danger/distribution/ci_source/ci_source_helpers.js:13:53)
at fulfilled (<project>/node_modules/danger/distribution/ci_source/ci_source_helpers.js:4:58)
at process._tickCallback (internal/process/next_tick.js:109:7)
error Command failed with exit code 1.
@deecewan deecewan added the bug label Mar 19, 2017
@deecewan deecewan self-assigned this Mar 19, 2017
@orta
Copy link
Member

orta commented Mar 21, 2017

Intertesting, could getPullRequests ever return a non-array type? In any case, lodash.find is in danger dep tree, replacing it with that would be a trivial fix

@deecewan
Copy link
Member Author

yeah, that's probably not a bad idea.

I can't see it ever not returning an array, unless the request fails.

@orta
Copy link
Member

orta commented Mar 21, 2017

Gonna make a release, so I'll fix this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants