Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendered out of order #845

Closed
chrisjaure opened this issue Mar 22, 2019 · 2 comments · Fixed by #1336
Closed

Markdown rendered out of order #845

chrisjaure opened this issue Mar 22, 2019 · 2 comments · Fixed by #1336
Labels

Comments

@chrisjaure
Copy link

chrisjaure commented Mar 22, 2019

Since upgrading from 3.3.0 to any version above 3.4.6 (for babel 7 compat), our calls to markdown have been rendering out of order in github pr comments.

I've verified in CI that the markdowns array is in the correct order, but when the comment is rendered, it's out of order. The order seems to be consistent though, and it will not change between subsequent pushes to the pr. The order did change, however, when I enabled debugging.

Using babel with or without presets makes no difference, but this is what I have now:

['@babel/preset-env', { targets: { node: 'current' } }]

Node version: v9.6.1

Let me know if there's any other info you need to debug the info.

@orta orta added the bug label Mar 23, 2019
@orta
Copy link
Member

orta commented Mar 23, 2019

Sounds like a bug yeah, I can't think of anything offhand which change which could make it indeterminate but never know with these types of things

@jamime
Copy link
Contributor

jamime commented Jun 6, 2019

I've noticed multiple calls to markdown are rendered in reverse order too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants