Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions condition #1013

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Fix GitHub Actions condition #1013

merged 2 commits into from
Mar 13, 2020

Conversation

rohit-gohri
Copy link
Member

Closes #856 & closes #936

@rohit-gohri rohit-gohri added the bug label Mar 6, 2020
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me!
Thank you

check for DANGER_GITHUB_API_TOKEN not present as it's priority is more if both it and GITHUB_TOKEN are present
@rohit-gohri
Copy link
Member Author

Not sure why the build is failing, it gets stuck on cache. All the tests are passing on local

@orta
Copy link
Member

orta commented Mar 13, 2020

Cool, let's get this in

@orta orta merged commit 0ca95c5 into danger:master Mar 13, 2020
rohit-gohri added a commit to rohit-gohri/danger-plugin-todos that referenced this pull request Mar 14, 2020
@rohit-gohri rohit-gohri deleted the fix-github-action-condition branch March 14, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants