Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take commit hash from CircleCI #1033

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Take commit hash from CircleCI #1033

merged 2 commits into from
Apr 16, 2020

Commits on Apr 16, 2020

  1. Take commit hash from CircleCI 

    Similar to the support of Jenkins commit hash. Fixes the same problem as
fixed in 73d1439:

> Danger doesn't currently have a way to understand on which commit is
> running. To get the current commit it asks to the platform the list of
> commits on the PR and assumes that is running on the last one. This
> creates few problems when you push a new commit before Danger runs on
> the CI for the previous commit, because it will assume is running on
> the last one, but that is actually not true, and that means that both
> the status update and the commit hash in the Danger comment signature
> will be wrong.
    @valscion
    valscion committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    dbac25a View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @valscion
    valscion committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    bf3e021 View commit details
    Browse the repository at this point in the history