Update uploadDockerImage.yml #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| env: | ||
| USERNAME: ${{ secrets.DOCKER_GITHUB_USERNAME }} | ||
| - name: Deploy | ||
| run: docker push docker.pkg.github.com/danger/danger-js/danger-danger-js:$VERSION |
There was a problem hiding this comment.
Requires auth to download (even public) images. Why not use docker.io/library/ instead?
There was a problem hiding this comment.
Yes, I know, I highlighted this in #810 (comment)
But the credentials we have are for GitHub package registry, then I'm fixing the current script, if use or not dockerhub is a separate discussion, and can be done in parallel.
|
@orta are you ok with this? If yes I will update the changelog and merge it |
|
Seems reasonable to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming
DOCKER_GITHUB_PASSWORDis actually a token with write permissions for the Packages of this repo