Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BitBucketServer does not encode filepath #1037

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

HonzaMac
Copy link

@HonzaMac HonzaMac commented May 7, 2020

Escaping filePath/filename when asking for diff on bitbucket server.

Fixes #1036

Having files under folders with white space will fail get content of file as it end in node-fetch error
TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters
@orta
Copy link
Member

orta commented May 7, 2020

Cool, nice work - this looks good 👍

@orta orta merged commit 0897c6c into danger:master May 7, 2020
@peril-staging
Copy link
Contributor

peril-staging bot commented May 7, 2020

Thanks for the PR @HonzaMac.

This PR has been shipped in v10.2.0 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Danger fail on files with special characters
2 participants