Remove extra logging that made it to master accidentally #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize my `origin` wasn't on my fork, and I ended up pushing some debug code directly! 馃槼 _I was tempted to force push, but I already made enough damage for one night_ 馃槥 In order to prevent me from doing something this silly again, what do you think of adding a branch protection rule to prevent direct pushes to `master`?
|
I'm cool with that as long as admins can still push to master (the deploy process does it on my computer) |
|
done 馃憤 |
|
I think you anyway are the only one that usually pushes to master @orta (mainly because of releases) then I think is totally fine to protect the master branch and leave admins out from branch rules |
|
Ha, it was good timing on your part - we had just started chatting about it in slack
|
|
鉂わ笍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize my
originwasn't on my fork, and I ended up pushing some debug code directly! 馃槼I was tempted to force push, but I already made enough damage for one night 馃槥
In order to prevent me from doing something this silly again, what do you think of adding a branch protection rule to prevent direct pushes to
master?