Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and version bump #107

Merged
merged 1 commit into from Jan 20, 2017
Merged

Update docs and version bump #107

merged 1 commit into from Jan 20, 2017

Conversation

orta
Copy link
Member

@orta orta commented Jan 20, 2017

  • Highlights danger pr
  • Explains how to do the token dance
  • Fixes links for the DSL shapes
  • Changes the DSL shape ordering so it's easier to read

@DangerCI
Copy link

DangerCI commented Jan 20, 2017 •
edited

Warnings
⚠️ Changes were made to package.json, but not to yarn.lock - Perhaps you need to run `yarn install`?

Generated by 🚫 dangerJS

@orta
Copy link
Member Author

orta commented Jan 20, 2017

Alright 🥇

@orta orta merged commit b05c4d1 into master Jan 20, 2017
@orta orta deleted the docs branch January 20, 2017 19:39
tivac
tivac reviewed Jan 20, 2017
View reviewed changes
source/dsl/GitDSL.ts
@@ -1,5 +1,8 @@
import { GitCommit } from "./Commit"

// This is `danger.github`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be danger.git?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damnnnnnnnn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tivac tivac tivac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orta @DangerCI @tivac