Add env variable to disable transpiling with typescript #1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble using
tsc
to compiledangerfile.ts
and it's currently throwingSyntaxError: Cannot use import statement outside a module
.My workflow runs all
.ts
files through Babel only, usestsc
as a linter only, and I havetarget
set toesnext
in mytsconfig.json
file:Danger seems to be transpiling with
tsc
butnode
can't execute its output since the target is so high. This PR adds theDANGER_DISABLE_TSC
flag for a developer to skiptsc
and use Babel.Idk if this is desired to be added to this project and I'm open to other implementations. Maybe the logic should be less about disabling tsc and more about forcing Babel. Or maybe a more robust solution to specify a specific transpiler would be better such as
DANGER_TRANSPILATION=off|babel|tsc
.