add path pattern filter option to linesOfCode #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this seems good to me - the reference docs are auto-generated so no need to worry there 👍🏻 |
|
@orta Is there anything you expect from my side? |
|
Nope, just didn't see it switch - so in theory, I expected this ping. Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter linesOfCode with glob pattern
When checking linesOfCode of a PR some teams might only want to include the
./srcfolder in the count. Or exclude the*.jsonfiles.This PR adds the optional parameter
patternto thelinesOfCodefunction. If provided, only file paths that match the glob pattern will be included in the resulting count. If omitted, the behavior remains unchanged.TODO
I'm aware that there is stuff to be done before merging this PR. Just opening as draft to get input on the idea.