Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use GitlabApi by oauth token #1144

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add ability to use GitlabApi by oauth token #1144

merged 1 commit into from
Jun 29, 2021

Conversation

Crazymax11
Copy link
Contributor

At my current project we don't have GitLab access token at CI, but instead we have oauth token. So I added a support of OAuth token usage for GitLab

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, yeah, this seems reasonable to me

@orta orta merged commit 632b6b7 into danger:main Jun 29, 2021
@Crazymax11
Copy link
Contributor Author

@orta sorry for commenting in closed PR, but I see release 10.6.5 at Github interface and don't see it at npm. Is it ok or something broken at project CI?

@HonzaMac
Copy link

Do we need adjust tests?

@orta
Copy link
Member

orta commented Jun 30, 2021

Travis CI had stopped running so this (a a few other PRs) felt green, but wasn't and that was breaking the deploy pipeline. Fixed it up this morning and shipped a new build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants