Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Xcode Cloud CI #1162

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Add support for Xcode Cloud CI #1162

merged 2 commits into from
Oct 12, 2021

Conversation

bobergj
Copy link
Contributor

@bobergj bobergj commented Oct 11, 2021

Add support for Xcode Cloud CI. Closes #1160

See Xcode Cloud environment variable reference: https://developer.apple.com/documentation/xcode/environment-variable-reference

Note for reviewer

CI
This variable evaluates to TRUE when the custom build script runs in Xcode Cloud. Use it to only run the build script when Xcode Cloud builds your project or workspace.

Since this variable has a very generic name, I added an additional check for the variable CI_XCODEBUILD_ACTION, which is also defined in all builds.

orta
orta approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me

@orta orta merged commit 933240d into danger:main Oct 12, 2021
@bobergj bobergj deleted the ci-xcode-cloud branch October 12, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for Xcode Cloud as CI environment
2 participants
@bobergj @orta