Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @types/jest to the latest version 馃殌 #119

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 30, 2017

Version 18.0.0 of @types/jest just got published.

Dependency @types/jest
Current Version 16.0.5
Type devDependency

The version 18.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of @types/jest.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 馃尨

@orta
Copy link
Member

orta commented Jan 30, 2017

Awesome

@orta orta merged commit 80ab229 into master Jan 30, 2017
@orta orta deleted the greenkeeper/@types/jest-18.0.0 branch January 30, 2017 18:46
@DangerCI
Copy link

Warnings
鈿狅笍 Please add a changelog entry for your changes.
鈿狅笍 Changes were made to package.json, but not to yarn.lock - Perhaps you need to run `yarn install`?

Generated by 馃毇 dangerJS

@orta
Copy link
Member

orta commented Jan 30, 2017

interesting, wonder if I should add an exception for greenskeeper to those rules ^

@macklinu
Copy link
Member

It doesn't look like Greenkeeper supports running yarn on PRs it opens - greenkeeperio/greenkeeper#314.

I think this Danger warning to run yarn install is appropriate, and we'll need to manually do that on PRs if we want Greenkeeper's updated package.json PR to also be reflected in the yarn.lock file.

@orta
Copy link
Member

orta commented Jan 30, 2017

馃憤 cool by me then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants