Allowing slashes in branch names #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbartho
approved these changes
May 30, 2022
|
Agree, looks good to me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently running into a few issues with branch names that include a slash like
feature/branch-name. So this means thatCODEBUILD_WEBHOOK_TRIGGERwill look likebranch/feature/branch-nameand danger then splits the string into an array and looks for the second index('feature'). This misses the rest of the name meaning that the PR cannot be found and Danger errors out.To combat this I've swapped out the split to arrays and seen as we know what the ENVs will be formatted we can just check the start of the strings and then replace the part we don't want.