Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates out the GitHub and GitHub api #136

Merged
merged 6 commits into from
Feb 2, 2017
Merged

Separates out the GitHub and GitHub api #136

merged 6 commits into from
Feb 2, 2017

Conversation

orta
Copy link
Member

@orta orta commented Jan 31, 2017

This isn't exactly perfect, but I dropped a feature that I think may still be needed for Peril to migrate to the latest Danger - so I'm going to re-add it, and cover it with tests :D

  • Add some more tests to the GitHubAPI
  • Add support for additional headers to the API object

@DangerCI
Copy link

DangerCI commented Jan 31, 2017

Warnings
⚠️ Changes were made to package.json, but not to yarn.lock - Perhaps you need to run `yarn install`?

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #136 into master will not impact coverage.

@@          Coverage Diff          @@
##           master   #136   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           3      3           
  Lines          90     92    +2     
  Branches       16     16           
=====================================
- Misses         90     92    +2
Impacted Files Coverage Δ
source/commands/danger-pr.ts 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b984983...741e747. Read the comment docs.

@orta
Copy link
Member Author

orta commented Feb 1, 2017

OK, this should be good for review - glad we got so much infra to tell me I'm doing things wrong :D

@orta
Copy link
Member Author

orta commented Feb 2, 2017

Alright, doing this 👍

@orta orta merged commit bb1879a into master Feb 2, 2017
@orta orta deleted the github_api branch February 2, 2017 16:28
@macklinu
Copy link
Member

macklinu commented Feb 2, 2017

Thanks for cleaning this up @orta 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants