Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI node to 16 to fix danger_babel_test test #1393

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 30, 2023

error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3"
error Found incompatible module.

NOTE: There's alternative solution: #1394

> error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3"
> error Found incompatible module.

- https://github.com/danger/danger-js/actions/runs/5706662040/job/15462583894?pr=1392#step:17:152
@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

This is easy change to fix failing CI. Probably proper solution would be to pin some packages. Create lockfile to track them.

Or just override node version for the failing danger_babel_test job only?

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

trying to use older create_react_app gives this error (and there is no global package installed)

✖ yarn create-react-app danger_babel_test

You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app

The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

could be reproduced with npx:

✖ npx create-react-app@4 danger_babel_test
npx: installed 67 in 5.637s

You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app

The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

@fbartho @orta this is to fix CI. See also the other solution:

Merge which one suits you more.

@orta
Copy link
Member

orta commented Jul 31, 2023

Thanks, yeah, this seems good to me 👍🏻

@orta orta merged commit b0e5f37 into danger:main Jul 31, 2023
2 checks passed
@glensc glensc deleted the bump-node-ci-16 branch July 31, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants