Use node 18 targets for yarn pkg #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commands are used by the brew taps and fixes the issue of having an outdated node version as part of the compiled binaries when installing with brew.
fbartho
approved these changes
May 21, 2024
|
Cool, makes sense to me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to node 18 in v12.0.0 the targets for the yarn pkg command was not updated as expected.
These commands are used by the homebrew-tap and fixes the issue of having an outdated node version as part of the compiled binaries when installing with brew as outlined in: #1448
This should suffice to fix the underlying issue, but I think it could be worth to look into the option of not bundling node in as part of the binary and instead use what is already available on the system it is running on.