introduce the eslint prefer-const rule
#16
Conversation
Some files already use `const`, but some use `let` nearly exclusive. Eslint offers the `prefer const` which detects possible constant values. This commit introduces the rule.
This commit fixes all the reported `prefer-const` violations .
| "prefer-const": ["error", { | ||
| "destructuring": "any", | ||
| "ignoreReadBeforeAssign": false | ||
| }], |
There was a problem hiding this comment.
yep definitely, this comes up all the time in code review for me artsy/emission#380 (review)
|
Hah - it was actually danger failing - "No Changelog changes!" We still don't have any feedback yet, was planning on starting to look at that today. I'm OK with this being red for now 👍 I also don't care about git history - so this is great |
|
Thanks @romankl - would you like to join the Danger org? we conform to the Moya Community Continuity - you're welcome to participate in PRs and help out at a level that works for you. |
|
@orta hey, whoaa that would be an honor - thank you! 👍 (right now it was just a small PR) |
|
sent - no problem, gives you more freedom, and eventually we'll add a Danger rule to ask, https://github.com/danger/danger/blob/master/Dangerfile#L14-L22 |
Some files already use
const, but some useletnearly exclusive. Eslint offers theprefer constwhich detects possible constant values. This PR introduces the rule and fixes all reported violations.I've created two separated commits for:
Should I squash them together?