support GitHub enterprise #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DANGER_GITHUB_API_BASE_URL like ruby version
macklinu
requested changes
Mar 13, 2017
source/platforms/github/GitHubAPI.ts
Outdated
| @@ -129,8 +129,10 @@ export class GitHubAPI { | |||
| if (this.token !== undefined) { | |||
| headers["Authorization"] = `token ${this.token}` | |||
| } | |||
|
|
|||
| return this.fetch(`https://api.github.com/${path}`, { | |||
|
|
|||
source/platforms/github/GitHubAPI.ts
Outdated
| return this.fetch(`https://api.github.com/${path}`, { | ||
|
|
||
| const baseUrl = process.env["DANGER_GITHUB_API_BASE_URL"] || "https://api.github.com" | ||
|
|
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 3 3
Lines 93 93
Branches 17 17
=====================================
Misses 93 93Continue to review full report at Codecov.
|
|
Thanks for the changes! |
|
When do you plan to release this ? |
|
very soon, just wanted to get #156 in and then do a bit of cleanup now |
|
shipped in 0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for DANGER_GITHUB_API_BASE_URL env var http://danger.systems/guides/getting_started.html#enterprise-github
Resolves #153